Skip to content

Warnings cleanup - #1401

Merged
j-c-c merged 3 commits into
developfrom
warnings_cleanup
Aug 4, 2026
Merged

Warnings cleanup#1401
j-c-c merged 3 commits into
developfrom
warnings_cleanup

Conversation

@j-c-c

@j-c-c j-c-c commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

clean up warnings listed in #1398

@j-c-c j-c-c self-assigned this Aug 3, 2026
@j-c-c j-c-c added cleanup extern Relating to external changes labels Aug 3, 2026
@codecov

codecov Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (83badf4) to head (8fbac93).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1401      +/-   ##
===========================================
+ Coverage    88.18%   90.66%   +2.47%     
===========================================
  Files          135      135              
  Lines        14927    14927              
===========================================
+ Hits         13164    13533     +369     
+ Misses        1763     1394     -369

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

garrettwrong
garrettwrong requested changes Aug 4, 2026
View reviewed changes

@garrettwrong garrettwrong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good thanks. I'll watch for the eigh update for this PR mentioned in the meeting, but if that doesn't work out, you can use this as a backup.

@j-c-c

j-c-c commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

This looks good thanks. I'll watch for the eigh update for this PR mentioned in the meeting, but if that doesn't work out, you can use this as a backup.

Thanks. Switched to eigh. The output of shrink_covar using eigh was allclose to the original implementation for all unit test cases.

@garrettwrong
garrettwrong marked this pull request as ready for review August 4, 2026 14:47
@garrettwrong
garrettwrong requested a review from janden as a code owner August 4, 2026 14:47
@garrettwrong

garrettwrong commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Sorry, hit "Ready For Review" instead of "Submit Review".

janden
janden approved these changes Aug 4, 2026
View reviewed changes

@janden janden left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-c-c
j-c-c merged commit 4f83e09 into develop Aug 4, 2026
60 of 61 checks passed
@j-c-c j-c-c mentioned this pull request Aug 4, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janden janden janden approved these changes
@garrettwrong garrettwrong garrettwrong approved these changes

Assignees

@j-c-c j-c-c

Labels

cleanup extern Relating to external changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j-c-c @garrettwrong @janden